-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Toolbar): add Typescript types #4600
refactor(Toolbar): add Typescript types #4600
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a few small questions. Also, if you used git to rename the file it will make the diff a bit easier to read (ie git mv packages/ibm-products/src/components/ComponentName/ComponentName.js packages/ibm-products/src/components/ComponentName/ComponentName.tsx
).
I used git to rename the file , but still it showed lot of diff. May be that is because I did yarn format after that. |
ba4870b
Contributes to #4274
Add Typescript types to Toolbar
What did you change?
Change extension to
.tsx
via gitCopy the PropTypes definitions above the component definition
Retool the PropTypes to be a TypeScript interface
Fixed the type errors
How did you test and verify your work?
Tested locally using storybook