Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Toolbar): add Typescript types #4600

Merged

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Mar 25, 2024

Contributes to #4274

Add Typescript types to Toolbar

What did you change?

Change extension to .tsx via git
Copy the PropTypes definitions above the component definition
Retool the PropTypes to be a TypeScript interface
Fixed the type errors

How did you test and verify your work?

Tested locally using storybook

@amal-k-joy amal-k-joy requested a review from a team as a code owner March 25, 2024 04:33
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 6e402cc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6616318872936300084994bb
😎 Deploy Preview https://deploy-preview-4600--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few small questions. Also, if you used git to rename the file it will make the diff a bit easier to read (ie git mv packages/ibm-products/src/components/ComponentName/ComponentName.js packages/ibm-products/src/components/ComponentName/ComponentName.tsx).

@amal-k-joy
Copy link
Contributor Author

Just have a few small questions. Also, if you used git to rename the file it will make the diff a bit easier to read (ie git mv packages/ibm-products/src/components/ComponentName/ComponentName.js packages/ibm-products/src/components/ComponentName/ComponentName.tsx).

I used git to rename the file , but still it showed lot of diff. May be that is because I did yarn format after that.

@matthewgallo matthewgallo added this pull request to the merge queue Apr 10, 2024
Merged via the queue into carbon-design-system:main with commit ba4870b Apr 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants