Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StatusIcon): add typescript types #4592

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

anamikaanu96
Copy link
Contributor

Contributes to #4504

Converted packages/ibm-products/src/components/StatusIcon/StatusIcon.js to packages/ibm-products/src/components/StatusIcon/StatusIcon.tsx

What did you change?

packages/ibm-products/src/components/StatusIcon/StatusIcon.tsx

How did you test and verify your work? Storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner March 21, 2024 10:02
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 15fca31
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6603d16eb5b25e00080cd107
😎 Deploy Preview https://deploy-preview-4592--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Nice work! One note for future components, if you use git mv [file].js [file].tsx it makes the git diff a bit easier to see the changes.

@matthewgallo matthewgallo added this pull request to the merge queue Mar 27, 2024
Merged via the queue into carbon-design-system:main with commit fada7db Mar 27, 2024
15 checks passed
@anamikaanu96 anamikaanu96 deleted the issue-4504 branch April 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants