fix(Decorator): breakout single Decorator into many smaller Decorators #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
paul-balchin-ibm
added
package: security
version: 2
davidmenendez
requested changes
Mar 13, 2024
Great idea. Thanks for the details in the PMs 🎉 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Mar 13, 2024
3f57a24
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4476
Issue
The single Decorator has complex and changing
proprelationships depending in thekindselected. This also requires complicated documentation to explain the different relationships.Solution
Create an internal DecoratorBase component, and build out sub components where their props are specific to each type.
Convert monolithic Decorator into smaller, more focused "sub types":
What did you change?
Too many files to list.
How did you test and verify your work?