-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dataspreadsheet): Duplication selection issue #4241 #4333
Merged
matthewgallo
merged 6 commits into
carbon-design-system:main
from
amal-k-joy:DataspreadSheet-refractor-duplicateSelection-4241
Mar 19, 2024
Merged
fix(Dataspreadsheet): Duplication selection issue #4241 #4333
matthewgallo
merged 6 commits into
carbon-design-system:main
from
amal-k-joy:DataspreadSheet-refractor-duplicateSelection-4241
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame cells to a selection
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
requested changes
Feb 27, 2024
packages/ibm-products/src/components/DataSpreadsheet/DataSpreadsheetBody.js
Show resolved
Hide resolved
…ithub.com:amal-k-joy/ibm-products into DataspreadSheet-refractor-duplicateSelection-4241
matthewgallo
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Merged
via the queue into
carbon-design-system:main
with commit Mar 19, 2024
8f2b275
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent Cmd (Ctrl) + click from re-adding the same cells to a selection
Contributes to #4241
Clear the selection , if same selection is made again
What did you change?
Created a method that will identify and remove any duplicate selection when any selection is made
How did you test and verify your work?
Verified locally