Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dataspreadsheet): Duplication selection issue #4241 #4333

Conversation

amal-k-joy
Copy link
Contributor

Prevent Cmd (Ctrl) + click from re-adding the same cells to a selection

Contributes to #4241

Clear the selection , if same selection is made again

What did you change?

Created a method that will identify and remove any duplicate selection when any selection is made

How did you test and verify your work?

Verified locally

@amal-k-joy amal-k-joy requested a review from a team as a code owner February 14, 2024 06:01
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit ae0b7d0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/65f7f67aa83e5a0007907002
😎 Deploy Preview https://deploy-preview-4333--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo
Copy link
Member

You can see this in the Actions tab in storybook, selection area change lists two selections but they are duplicates.
image

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@matthewgallo matthewgallo added this pull request to the merge queue Mar 19, 2024
Merged via the queue into carbon-design-system:main with commit 8f2b275 Mar 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants