Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): address ssr bug in nested row hook (v2) #4205

Conversation

matthewgallo
Copy link
Member

Contributes to #4203

Adds typeof check before accessing document.activeElement, this prevents issues with SSR apps/nextjs.

What did you change?

packages/ibm-products/src/components/Datagrid/useNestedRowExpander.js

How did you test and verify your work?

Storybook

@matthewgallo matthewgallo requested a review from a team as a code owner February 2, 2024 16:06
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9d618ab
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/65bd1319aff1d90008aed7e9
😎 Deploy Preview https://deploy-preview-4205--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo added this pull request to the merge queue Feb 5, 2024
Merged via the queue into carbon-design-system:main with commit 0ec7196 Feb 5, 2024
16 checks passed
@matthewgallo matthewgallo deleted the 4203-ssr-issue-in-datagrid-nested-row_v2 branch February 5, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants