Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataGrid): column customisation not unselect locked columns #4191

Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix(DataGrid): column customisation not unselect locked columns #4191

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de95557
fix(DataGrid): column customisation not unselect locked columns
Ratheeshrajan Feb 1, 2024
e1900c3
chore(DataGrid): remove unwanted map
Ratheeshrajan Feb 1, 2024
c1c0fce
Merge branch 'main' into customize-column-selectAll
Ratheeshrajan Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ibm-products/src/components/Datagrid/Datagrid/addons/CustomizeColumns/Columns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const Columns = ({
[columns, setColumnsObject]
);

const filteredStickyColumn = columns?.filter((item) => !item.sticky)?.map(item=> item);
Ratheeshrajan marked this conversation as resolved.
Show resolved Hide resolved
return (
<div
className={`${blockClass}__customize-columns-column-list`}
Expand Down Expand Up @@ -89,7 +90,7 @@ const Columns = ({
}
onChange={() => {
onSelectColumn(
columns,
filteredStickyColumn,
getVisibleColumnsCount() !== columns.length
);
}}
Expand Down
2 changes: 1 addition & 1 deletion ...cts/src/components/Datagrid/Datagrid/addons/CustomizeColumns/CustomizeColumnsTearsheet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const CustomizeColumnsTearsheet = ({
const onCheckboxCheck = (col, value) => {
const changedDefinitions = columnObjects.map((definition) => {
if (
(Array.isArray(col) && col.indexOf(definition) != null) ||
(Array.isArray(col) && col.indexOf(definition) != -1) ||
definition.id === col.id
) {
return { ...definition, isVisible: value };
Expand Down
Loading