Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port InterstitialScreen component to V2 #4094

Merged
merged 8 commits into from
Feb 2, 2024
Merged

feat: port InterstitialScreen component to V2 #4094

merged 8 commits into from
Feb 2, 2024

Conversation

jlongshore
Copy link
Contributor

Contributes to 4041

Added the following components, stories, and tests:
InterstitialScreen
InterstitialScreenView
InterstitialScreenViewModule

How did you test and verify your work?
Tests, and manual testing in Storybook.

@jlongshore jlongshore added version: 2 Carbon 11 / v2 area: plg ✨ Product-led growth, includes novice to pro labels Jan 19, 2024
@jlongshore jlongshore requested a review from a team as a code owner January 19, 2024 23:31
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit b059ec2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/65bcfa2065a7bc00086f0133
😎 Deploy Preview https://deploy-preview-4094--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidmenendez
davidmenendez previously approved these changes Jan 23, 2024
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but same comment about PR size

@jlongshore jlongshore added this pull request to the merge queue Feb 2, 2024
Merged via the queue into carbon-design-system:main with commit 827d97d Feb 2, 2024
13 checks passed
@jlongshore jlongshore deleted the interstitialscreen_v2_4041 branch February 2, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: plg ✨ Product-led growth, includes novice to pro version: 2 Carbon 11 / v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants