-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port InterstitialScreen component to V2 #4094
Merged
jlongshore
merged 8 commits into
carbon-design-system:main
from
jlongshore:interstitialscreen_v2_4041
Feb 2, 2024
Merged
feat: port InterstitialScreen component to V2 #4094
jlongshore
merged 8 commits into
carbon-design-system:main
from
jlongshore:interstitialscreen_v2_4041
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlongshore
added
version: 2
Carbon 11 / v2
area: plg ✨
Product-led growth, includes novice to pro
labels
Jan 19, 2024
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fixed a comment to be a little more readable
davidmenendez
previously approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving but same comment about PR size
davidmenendez
approved these changes
Feb 2, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 2, 2024
827d97d
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to 4041
Added the following components, stories, and tests:
InterstitialScreen
InterstitialScreenView
InterstitialScreenViewModule
How did you test and verify your work?
Tests, and manual testing in Storybook.