Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Datagrid): add test coverage for new hook (v1) #3884

Conversation

matthewgallo
Copy link
Member

Note: #3864 Should be reviewed/merged first

Contributes to #3821

Adds test coverage to new expander hooks to keep focus when applicable.

What did you change?

packages/ibm-products/src/components/Datagrid/Datagrid.test.js

How did you test and verify your work?

Storybook and made sure all tests pass and meet coverage requirements

@matthewgallo matthewgallo requested a review from a team as a code owner December 1, 2023 14:51
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for v1-carbon-for-ibm-products ready!

Name Link
🔨 Latest commit da32dd1
🔍 Latest deploy log https://app.netlify.com/sites/v1-carbon-for-ibm-products/deploys/656e3767dec9f600083fd6cc
😎 Deploy Preview https://deploy-preview-3884--v1-carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidmenendez
davidmenendez previously approved these changes Dec 1, 2023
Co-authored-by: Elysia <[email protected]>
@matthewgallo matthewgallo merged commit 4bac76b into carbon-design-system:main_v1 Dec 4, 2023
13 checks passed
@matthewgallo matthewgallo deleted the 3821-use-focus-expander-test-coverage-v1 branch December 4, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants