Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade storybook #3883

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Dec 1, 2023

Upgrades storybook packages to latest, this fixes some unexpected console errors that have been thrown when hovering over items in the left navigation and also introduces mdx2, allowing us to once again use mdx for our doc files 🎉

What did you change?

Ran npx storybook@latest upgrade to upgrade all storybook packages from packages/core.

How did you test and verify your work?

Confirmed that storybook started locally and added mdx doc file for TagSet just to test (reverted it back until we come up with a plan for autodoc usage vs mdx).

@matthewgallo matthewgallo requested a review from a team as a code owner December 1, 2023 14:13
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit a55f626
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6569eca6f5be5b0008ae6ac4
😎 Deploy Preview https://deploy-preview-3883--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo added type: stories 📚 Updates to Storybook examples or docs type: infrastructure 🤖 Issues related to devops, builds, packaging labels Dec 1, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a mix of double and single quotes.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good. Just noticing some mixed usage of single and double quotes in main.js.

@elycheea elycheea added this pull request to the merge queue Dec 1, 2023
Merged via the queue into carbon-design-system:main with commit 366f662 Dec 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure 🤖 Issues related to devops, builds, packaging type: stories 📚 Updates to Storybook examples or docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants