Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CreateTearsheet): pass props to story #3866

Merged

Conversation

elycheea
Copy link
Contributor

@elycheea elycheea commented Nov 29, 2023

Closes to #3865

Tiny fix ... would have let it slide but was reading and investigated so figured better to commit the fix since it took me long enough to remember that we had the preview components for Create ... 🙈
Fixes an issue where changing verticalPosition in Create Tearsheet stories didn’t actually do anything. 🤔

What did you change?

💤

How did you test and verify your work?

Storybook and CI

@elycheea elycheea added type: docs 📖 Improvements or additions to documentation component: CreateTearsheet Create flows labels Nov 29, 2023
@elycheea elycheea requested a review from a team as a code owner November 29, 2023 21:11
Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 122b437
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6567a91c23672000080af7c6
😎 Deploy Preview https://deploy-preview-3866--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea elycheea linked an issue Nov 29, 2023 that may be closed by this pull request
@matthewgallo matthewgallo added this pull request to the merge queue Nov 29, 2023
Merged via the queue into carbon-design-system:main with commit 4c2ffeb Nov 29, 2023
16 checks passed
paul-balchin-ibm pushed a commit to paul-balchin-ibm/ibm-products that referenced this pull request Dec 1, 2023
@elycheea elycheea deleted the 3865-create-flow-story branch December 15, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CreateTearsheet Create flows type: docs 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(Create): discrepancy in create flow component spacing
3 participants