Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Datagrid): remove warning about drag and drop rework #3541

Conversation

matthewgallo
Copy link
Member

Contributes to #3478

We can safely remove the warning notification we added on the ColumnCustomization story for the Datagrid now that we have the dnd-kit approach merged. Thanks to @lee-chase! 🥳 🎉

What did you change?

Removed notification from ColumnCustomization story

How did you test and verify your work?

Storybook

@matthewgallo matthewgallo requested a review from a team as a code owner October 4, 2023 13:32
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 6ad9237
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/651d69814d9a2f0007e85f09
😎 Deploy Preview https://deploy-preview-3541--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea elycheea added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2023
@matthewgallo matthewgallo added this pull request to the merge queue Oct 4, 2023
Merged via the queue into carbon-design-system:main with commit b95c73b Oct 4, 2023
@matthewgallo matthewgallo deleted the remove-drag-drop-warning-from-customize-col-story branch October 4, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

2 participants