Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): add batch actions to clickable row with panel story (v1) #3327

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Jul 26, 2023

Contributes to #3226 and #2607

Adds batch actions to the clickable row with panel story to provide a more detailing use case. I also fix the alignment of the batch action buttons in this PR as well.

What did you change?

  • Added batch actions to clickable with panel story
  • Removed styling causing batch action layout issues

How did you test and verify your work?

Storybook

Also discovered a storybook config option to allow for non story exports within *.stories.js files. I've utilized it here for getBatchActions which reduces our overall footprint.

@matthewgallo matthewgallo requested a review from a team as a code owner July 26, 2023 14:31
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for v1-carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 638c92f
🔍 Latest deploy log https://app.netlify.com/sites/v1-carbon-for-ibm-products/deploys/64c13247e06ea60008953f25
😎 Deploy Preview https://deploy-preview-3327--v1-carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo merged commit 6259c63 into carbon-design-system:main_v1 Jul 27, 2023
@matthewgallo matthewgallo deleted the 3226-batch-actions-clickable-row-v1 branch July 27, 2023 14:09
@elycheea elycheea linked an issue Jul 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Improve how batch action works with other plugins
2 participants