feat: Remove react resize detector #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lee-chase
changed the title
davidmenendez
changed the title
elycheea
reviewed
Apr 24, 2023
packages/cloud-cognitive/src/global/js/hooks/useWindowScroll.js
Outdated
Show resolved
Hide resolved
packages/cloud-cognitive/src/global/js/hooks/useWindowResize.js
Outdated
Show resolved
Hide resolved
packages/cloud-cognitive/src/components/Tearsheet/TearsheetShell.js
Outdated
Show resolved
Hide resolved
packages/cloud-cognitive/src/components/PageHeader/PageHeader.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Elysia <[email protected]>
Co-authored-by: Elysia <[email protected]>
✅ Deploy Preview for v11-carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for v11-carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
matthewgallo
approved these changes
Apr 25, 2023
|
@lee-chase Can this also be removed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2744
V7 of ReactResizeObserver can result in the error shown in #2744 but the error appears to be a timing issue of some description.
The author fixed a similar looking issue in V8, but it persists in our storybook. In V9 there were more extensive changes that stopped our current usage working.
This PR removes ReactResizeObserver in favor of wrapping ResizeObserver (now standard) in a hook.
What did you change?
How did you test and verify your work?
NOTE: Storybook 6 reports the following error which would appear to be related this issue fixed only in Storybook 7. storybookjs/storybook#18716