feat(Datagrid): Filter flyout #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AlexanderMelox
changed the title
|
🚀 PR is ready for review, the latest commit adds batch update method. Just need to add the radio button filter type but that should be easy.
|
matthewgallo
reviewed
Nov 2, 2022
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/Filtering/FilterFlyout.js
Outdated
Show resolved
Hide resolved
matthewgallo
reviewed
Nov 2, 2022
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/Filtering/FilterFlyout.js
Outdated
Show resolved
Hide resolved
matthewgallo
reviewed
Nov 2, 2022
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/Filtering/FilterFlyout.js
Outdated
Show resolved
Hide resolved
…itive into 2251--filter-flyout-import
|
Added FilterSummary to this PR 🍾 |
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/Filtering/FilterProvider.js
Outdated
Show resolved
Hide resolved
packages/cloud-cognitive/src/components/Datagrid/Datagrid.stories.js
Outdated
Show resolved
Hide resolved
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/Filtering/FilterFlyout.js
Outdated
Show resolved
Hide resolved
matthewgallo
requested changes
Nov 21, 2022
matthewgallo
previously approved these changes
Nov 28, 2022
|
@elycheea and I were taking a look earlier at why netlify seems to be failing. Looks related to storybookjs/storybook#19927. Lets take a closer look before merging! |
…itive into 2251--filter-flyout-import
matthewgallo
approved these changes
Nov 29, 2022
Ratheeshrajan
pushed a commit
to matthewgallo/ibm-products
that referenced
this pull request
Jan 31, 2023
* fix: filter flyout doesn't close * feat(Datagrid): Added number and dropdown input filter * feat(Datagrid): added filterTypes and date between filter * feat: added cell key to headers and hasClickedOnDatePicker * fix: removed unused imports * chore: update yarn lock and cache * chore(Datagrid): moved filterTypes to useFiltering.js * feat(Datagrid): changed status icon to return obj * feat(datagrid): refactor date filter * fix(datagrid): removed console.log * feat(datagrid): refactored number filter * feat(datagrid): refactored dropdown filter * feat(datagrid): removed type and changed date filter * fix(datagrid): fixed filterTypes key to reflect changes * fix(datagrid): changed status_icon to password strength * feat(datagrid): adds checkbox filter * feat(datagrid): adding batch actions * feat(datagrid): adds batch filter method * fix(datagrid): removed unnecessary date function * fix(datagrid): added nullish coalescing to filterProps check * fix(datagrid): this component is no longer needed * feat(datagrid): adds props for action set labels and callbacks * feat(datagrid): added flyoutIconDescription prop * feat(datagrid): added missing copyright headers * feat(datagrid): added carbon prefixes * feat(datagrid): overrides action set to display 48px button size * feat(datagrid): adds checkbox filter * fix(datagrid): changes chance for each individual property * feat(datagrid): added extra callback functions to props * fix(datagrid): added open class back * feat(datagrid): refactored flyout components * feat(datagrid): refactored filters to be render in flyout * feat(datagrid): fixed resetting filters * fix(datagrid): action set styles * fix(datagrid): redundant change * fix(datagrid): redundant change * fix(datagrid): fixed css properties order * fix(datagrid): fixed constant typo * fix(datagrid): fix linting * chore(datagrid): fix linting issues * feat(datagrid): adds variation prop * feat: adds FilterSummary * fix: removes stylint-disable * fix(FilterSummary): changed filters prop * feat(FilterFlyout): adding filter tags * chore(FilterSummary): clean up adding reset filters * feat(Datagrid): adds FilterSummary * fix: added null check to filterProps * feat(Datagrid): adds optional onChange from user * feat(Datagrid): added constant, storybook actions and emptystate props * fix: yarn.lock * chore: format files Co-authored-by: Matt Gallo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2251
This adds the filter flyout component and adds filtering to the Datagrid component