Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): isolate styles per story #15

Merged

Conversation

SimonFinney
Copy link
Contributor

@SimonFinney SimonFinney commented Jul 7, 2020

This PR is a request for comments and proposes isolating styles as a workaround for storybookjs/storybook#729 on a per-story basis.

The reason for this is to verify individual styles as a unit on a truly per-component basis from each package, allowing us to better surface and identify integration issues when composing components and styles from several packages.

Changelog

New

  • Add global Carbon Storybook styles to prevent CSS reset and add font-face declarations
  • Add webpack configuration that enables injecting style tags on and off
  • Add decorator to toggle style tags on and off when a story is created or destroyed

@SimonFinney SimonFinney requested a review from a team as a code owner July 7, 2020 18:59
@netlify
Copy link

netlify bot commented Jul 7, 2020

Deploy preview for ibm-cloud-paks ready!

Built with commit 60367af

https://deploy-preview-15--ibm-cloud-paks.netlify.app

@SimonFinney SimonFinney merged commit c9eb079 into carbon-design-system:master Jul 10, 2020
@SimonFinney SimonFinney deleted the style-structure-isolated branch July 10, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants