Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript types to OptionsTile #4281

Closed
6 tasks
Tracked by #4232
matthewgallo opened this issue Feb 8, 2024 · 0 comments
Closed
6 tasks
Tracked by #4232

Add Typescript types to OptionsTile #4281

matthewgallo opened this issue Feb 8, 2024 · 0 comments
Assignees

Comments

@matthewgallo
Copy link
Member

matthewgallo commented Feb 8, 2024

As we add Typescript support, want to call out a few helpful tips from the Carbon TypeScript guide that is largely relevant to our library as well.

Changing the extension via git

When changing the file extension — do not simply rename the file. Instead, change the extension via git.

For example,

git mv packages/ibm-products/src/components/ComponentName/ComponentName.js packages/ibm-products/src/components/ComponentName/ComponentName.tsx

Do not add types to internal components or functions

Testing changes

A few different options for testing changes —

  • At the bottom of a file, write a dummy component that uses the component that you’re converting to ensure that you can still pass all appropriate props.
  • Take a storybook example for a component, copy and paste it into the bottom of the .tsx file and validate whether or not it accepts the props as you’ve defined them.

Tasks

Preview Give feedback

Resources

Carbon’s guide on adding component types

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Feb 8, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Community backlog 🚞 in Carbon for IBM Products Feb 14, 2024
@elycheea elycheea moved this from Community backlog 🚞 to Backlog 🌋 in Carbon for IBM Products Mar 7, 2024
@davidmenendez davidmenendez moved this from Backlog 🌋 to In progress in Carbon for IBM Products Mar 18, 2024
@davidmenendez davidmenendez moved this from In progress to In review 👀 in Carbon for IBM Products Mar 26, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🚀 in Carbon for IBM Products Mar 27, 2024
wkeese added a commit to wkeese/carbon-ibm-products that referenced this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants