Skip to content

Commit

Permalink
Merge branch 'main' into issue-4140
Browse files Browse the repository at this point in the history
  • Loading branch information
davidmenendez authored Dec 17, 2024
2 parents 805df30 + 9595f65 commit f9ad957
Show file tree
Hide file tree
Showing 63 changed files with 2,802 additions and 1,002 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,28 +182,6 @@ jobs:
name: playwright-avt-report
path: .playwright

vrt-runner:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '20.x'
cache: yarn
- name: Install
run: yarn
- name: Install browsers
run: yarn playwright install --with-deps
- name: Build project
run: yarn build
- name: Run VRT
working-directory: packages/core
env:
PERCY_TOKEN: web_d04495b0b413d61c2ea6b9118d1748b43f4fdd58d17ebe453ef8e0016b5766e4
run: yarn percy storybook storybook-static

avt:
if: ${{ always() }}
runs-on: ubuntu-latest
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/process-pr-review-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ jobs:
github.event.workflow_run.conclusion == 'success'
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '20.x'
cache: yarn
- uses: ./actions/add-review-labels
with:
APP_ID: ${{ secrets.APP_ID }}
Expand Down
11 changes: 11 additions & 0 deletions config/jest-config-ibm-cloud-cognitive/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.15.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-12-09)


### Bug Fixes

* update accessibility-checker version ([#6525](https://github.com/carbon-design-system/ibm-products/issues/6525)) ([d8c7051](https://github.com/carbon-design-system/ibm-products/commit/d8c70518087e7e41fdf1aa45cbbf692389058d56))





# [1.14.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-12-04)

**Note:** Version bump only for package jest-config-ibm-cloud-cognitive
Expand Down
2 changes: 1 addition & 1 deletion config/jest-config-ibm-cloud-cognitive/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jest-config-ibm-cloud-cognitive",
"private": true,
"version": "1.14.0",
"version": "1.15.0-rc.0",
"license": "Apache-2.0",
"main": "index.js",
"repository": {
Expand Down
8 changes: 8 additions & 0 deletions config/storybook-addon-carbon-theme/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.5.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-09)

**Note:** Version bump only for package @carbon/storybook-addon-theme





# [2.4.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-04)

**Note:** Version bump only for package @carbon/storybook-addon-theme
Expand Down
2 changes: 1 addition & 1 deletion config/storybook-addon-carbon-theme/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/storybook-addon-theme",
"description": "Carbon theme switcher for Storybook",
"version": "2.4.0",
"version": "2.5.0-rc.0",
"license": "Apache-2.0",
"main": "dist/react.js",
"repository": {
Expand Down
51 changes: 51 additions & 0 deletions e2e/components/Checklist/Checklist-test.avt.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,56 @@ test.describe('Checklist @avt', () => {
},
});
await expect(page).toHaveNoACViolations('Checklist @avt-default-state');

const buttonEle = page.locator('[aria-label="Checklist toggle"]');
const viewButton = page.getByRole('button', { name: 'View all (10)' });
const tooltipContent = await page.getByText('Toggle');
const taskButtons = page.locator('[title="Task name"]');
//press tab to move focus to buttonELement
await page.keyboard.press('Tab');
await expect(buttonEle).toBeInViewport();
await expect(buttonEle).toBeFocused();

//check the checklist is expanded
await expect(buttonEle).toHaveAttribute('aria-expanded', 'true');
await expect(viewButton).toBeVisible();
//Press enter to collapse the checklist
await page.keyboard.press('Enter');
await expect(buttonEle).toHaveAttribute('aria-expanded', 'false');

//Press escape to hide tooltip
await page.keyboard.press('Escape');
await expect(tooltipContent).not.toBeVisible();

//Press tab to move focus to 1st Task name
await page.keyboard.press('Tab');
await expect(taskButtons.nth(0)).toBeFocused();

//Press tab to move focus to 2nd Task name
await page.keyboard.press('Tab');
await expect(taskButtons.nth(1)).toBeFocused();

//Press tab to move focus to 3rd Task name
await page.keyboard.press('Tab');
await expect(taskButtons.nth(2)).toBeFocused();

//Press tab to move focus to View all(10) button
await page.keyboard.press('Tab');
await expect(viewButton).toBeFocused();

//check button element is showing Toggle tooltip while hovering
await buttonEle.hover();
await expect(tooltipContent).toBeVisible();
});

test('@avt-task-state', async ({ page }) => {
await visitStory(page, {
component: 'Checklist',
id: 'ibm-products-onboarding-checklist--task-states',
globals: {
carbonTheme: 'white',
},
});
await expect(page).toHaveNoACViolations('Checklist @avt-task-state');
});
});
Loading

0 comments on commit f9ad957

Please sign in to comment.