fix(Condition builder): initial state getting reset on re-rendering

carbon-design-system · Dec 9, 2024 · 5c32463 · 5c32463
1 parent 6e58e9d
commit 5c32463
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/...ducts/src/components/ConditionBuilder/ConditionBuilderContent/ConditionBuilderContent.tsx b/...ducts/src/components/ConditionBuilder/ConditionBuilderContent/ConditionBuilderContent.tsx
@@ -99,8 +99,7 @@ const ConditionBuilderContent = ({
   }, [actionState]);
   useEffect(() => {
     if (initialState?.enabledDefault) {
-      setRootState?.(initialConditionState.current as ConditionBuilderState);
-      initialConditionState.current = null;
+      setRootState?.(initialState.state);
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [initialState]);
@@ -120,12 +119,17 @@ const ConditionBuilderContent = ({
 
   const onRemove = useCallback(
     (groupId) => {
+      const groups = rootState?.groups?.filter(
+        (group) => groupId !== group?.id
+      );
       setRootState?.({
         ...rootState,
-        groups: rootState
-          ? rootState?.groups?.filter((group) => groupId !== group?.id)
-          : [],
+        groups: rootState ? groups : [],
       });
+      //set the initial state to empty.
+      if (groups?.length === 0) {
+        initialConditionState.current = null;
+      }
     },
     [setRootState, rootState]
   );