Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feedback dialog #772

Merged
merged 31 commits into from
Mar 16, 2020
Merged

feat: Feedback dialog #772

merged 31 commits into from
Mar 16, 2020

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Mar 9, 2020 •
edited
Loading

Closes #771

Stuff I guessed on:

  • Shadows (used same as switcher)
  • Comments scroll to top on blur (losing focus), only show gradient when user isn't actively typing.
  • Radio button focused = 2px outline (as opposed to just 1px when selected but not focused)

Todo:

  • - Animations
  • - Only appear after scrolling ~300px
  • - hover for inputs, cursor on svg
  • - fieldset margin top
  • mobile zamboni on iOS
  • mobile font size to avoid zoom
  • mobile focus
  • flexible icon

@vpicone vpicone requested review from a team, sstrubberg and jnm2377 and removed request for a team March 9, 2020 20:18
@vercel
Copy link

vercel bot commented Mar 9, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/kwgyk7ewi
✅ Preview: https://gatsby-theme-carbon-git-fork-vpicone-feedback-dialog.carbon-design-system.now.sh

@vpicone vpicone requested a review from jeanservaas March 10, 2020 03:11
@jnm2377

This comment has been minimized.

Sign in to view
@jnm2377
Copy link
Contributor

jnm2377 commented Mar 10, 2020

Only real feedback is the focus border on the comment box, but otherwise, lgtm. 👍

@vpicone
Copy link
Contributor Author

vpicone commented Mar 10, 2020

@jnm2377 opted to use the carbon component, theming was easier than I thought

@vercel vercel bot temporarily deployed to Preview March 11, 2020 03:14 Inactive
sstrubberg
sstrubberg reviewed Mar 13, 2020
View reviewed changes
packages/gatsby-theme-carbon/package.json Outdated
@@ -58,6 +59,7 @@
"prop-types": "^15.7.2",
"react-helmet": "^6.0.0-beta",
"react-scroll-up": "^1.3.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove react-scroll-up now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@vercel vercel bot temporarily deployed to Preview March 14, 2020 00:58 Inactive
@vpicone
Copy link
Contributor Author

vpicone commented Mar 14, 2020

@jeanservaas updated with:

  • animating checkmark
  • full width on mobile
  • launch button styles

aagonzales
aagonzales requested changes Mar 16, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing background hover change for "rate your experience" tiles
    image

  • In the new spec, Jeannie says the background hover of the wink trigger should be Gray60 Hover, it is currently #000

image

@vpicone
Copy link
Contributor Author

vpicone commented Mar 16, 2020

@aagonzales @jeanservaas and @mjabbink switched it to be #000 to match the back-to-top button.

Screen Shot 2020-03-16 at 11 52 29 AM

Good catch on the hover, it's fixed!

@vpicone
Copy link
Contributor Author

vpicone commented Mar 16, 2020

@aagonzales switched from #000 to gray-100

@vpicone vpicone requested a review from aagonzales March 16, 2020 17:20
aagonzales
aagonzales approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vpicone vpicone changed the title Feedback dialog feat: Feedback dialog Mar 16, 2020
@vpicone vpicone merged commit cb12399 into carbon-design-system:master Mar 16, 2020
@vpicone vpicone deleted the feedback-dialog branch March 16, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

@aagonzales aagonzales aagonzales approved these changes

@jeanservaas jeanservaas Awaiting requested review from jeanservaas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add modeless feedback dialog for each page
4 participants
@vpicone @jnm2377 @aagonzales @sstrubberg