Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): update carbon to v10.9.1 #626

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

joshblack
Copy link
Contributor

This PR is currently introducing the Release Candidates for our v10.9.1 release. When v10.9.1 moves to stable, we'll also update this to include v10.9.1 latest! (Unless we want to merge this and then do a separate one)

The changelog for the current release is available here

Changelog

New

Changed

  • Update dependencies to v10.9.1 RC variants

Removed

@vercel
Copy link

vercel bot commented Jan 6, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/8j5jbpgzk
✅ Preview: https://gatsby-theme-carbon-git-fork-joshblack-release-v1091.carbon-design-system.now.sh

@vpicone
Copy link
Contributor

vpicone commented Jan 7, 2020

closing in favor of #632

@vpicone vpicone closed this Jan 7, 2020
@joshblack
Copy link
Contributor Author

@vpicone are there any changes to package.json in #632? Seemed like lockfile changes 🤔 Want us to open up a separate PR for the final version?

@vpicone
Copy link
Contributor

vpicone commented Jan 7, 2020

@joshblack Yarn doesn't update the package.json unless the new version doesn't match the semver notation there. Since all the upgrades in #632 are patch/minor, the semver in package.json is still correct/true for them.

Also I forgot I upgrade carbon with the tabs refactor in #611 haha.

@joshblack
Copy link
Contributor Author

joshblack commented Jan 7, 2020

@vpicone for dependents of the theme would we want them on a specific version? Or at least a minimally compatible version

@vpicone
Copy link
Contributor

vpicone commented Jan 7, 2020

@joshblack hmmm yeah that makes sense

@vpicone
Copy link
Contributor

vpicone commented Jan 7, 2020

@joshblack I think I did update the package.json to 10/7.9 for the tabs because we were leaning on that new feature.

@vpicone vpicone reopened this Jan 7, 2020
@joshblack joshblack changed the title chore(dependencies): update carbon to v10.9.1-rc.0 chore(dependencies): update carbon to v10.9.1 Jan 13, 2020
@vpicone vpicone merged commit 874a2ba into carbon-design-system:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants