-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(demo-site): remove demo site package #316
chore(demo-site): remove demo site package #316
Conversation
Thanks Andy for raising the PR. Please take a look at the failed PR checks. It seems that the web extension cannot be built now. |
Been digging into that - it's definitely still building locally on the same versions of node & npm. |
I can reporduce the issue locally. Seems to be an order of operations thing. The build fails on This same issue is present on the |
This is working for me locally. Lets see how it does in CI: #318 |
CI is clean over in #318 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check if lerna config needs to be adjusted
@motou you mean the lerna.json file? {
"version": "2.3.3",
"npmClient": "yarn",
"useWorkspaces": true
} What would need changed? |
Yes, we may need to remove the workspaces that are already removed |
On the other side, if the demo site is removed, please provide a website that uses Carbon v10 in the readme file so that the dev tools can be triggered. |
Note
This PR is a part of my exploration into the devtools to understand how they work, how to update them for use with the next version of Carbon and carbon-based libraries, and how to make them more maintainable going forward. Full documentation is available here (w3ID required)
This PR removes the demo-site package, for several reasons:
gh-pages
branch which appears to be just a static build.Changelog
Removed