Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update top positioning for filter in app icons tab #1042

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix: update top positioning for filter in app icons tab #1042

merged 1 commit into from
Nov 10, 2021

Conversation

aledavila
Copy link
Contributor

Closes #1009

Updates app icon filter row positioning

Changelog

Changed

  • changing position top: 7rem to top: 6.95rem to acconut for the pixel difference.

Make sure the tabs look good

@aledavila aledavila requested review from a team, vpicone and sstrubberg and removed request for a team November 9, 2021 19:43
@vercel
Copy link

vercel bot commented Nov 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/design-language-website/APZiyWa4csb8JD779Y925T8kjei1
✅ Preview: https://design-language-website-git-fork-al-f57f5d-carbon-design-system.vercel.app

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alisonjoseph alisonjoseph merged commit 1fede05 into carbon-design-system:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App icon library tabs adds a pixel under tabs when scrolling
2 participants