Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codesnippet): type specs codesnippet uses white theme instead of default g10 #1040

Merged

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Nov 3, 2021

Closes #1010

Changelog

  • updates dependencies
  • makes codesnippet use white theme instead of g10 theme
    • GTC is using gray10 theme for the main content pages. In g10 theme, codesnippet is white. But that doesn't work for typespec component bc it's a white snippet on white bg. This adds zoned theming to just the inline snippet so it uses white theme tokens (gray bg)
    • see additional pictures below that go with the explanation

Screen Shot 2021-11-03 at 1 10 55 PM

Screen Shot 2021-11-03 at 1 07 19 PM

@jnm2377 jnm2377 requested review from a team, vpicone and sstrubberg and removed request for a team November 3, 2021 18:15
@vercel
Copy link

vercel bot commented Nov 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/design-language-website/RpDUmuNT9u282dc7VcZLc86y8hBU
✅ Preview: https://design-language-website-git-fork-jn-74c8e5-carbon-design-system.vercel.app

@sstrubberg sstrubberg merged commit 3e8bcdc into carbon-design-system:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix[type specs component]: inline code snippet incorrect
2 participants