New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): add closeButtonLabel prop, add default value #9998

Merged

kodiakhq merged 4 commits into carbon-design-system:main from dakahn:add-default-label-to-modal-close

Oct 30, 2021

Contributor

dakahn commented Oct 29, 2021

adds ability to set a label on the close button (for translation purposes, and sets a default value to clear accessibility checker errors

Testing / Reviewing

either pass a closeButtonLabel prop, or check to see that the close button has the appropriate label in the dom/accessibility tree 🏄🏾


          fix(Modal): add closeButtonLabel prop, add default value

22f34bf

dakahn requested review from joshblack and sstrubberg

October 29, 2021 16:56

dakahn requested review from a team as code owners

October 29, 2021 16:56

tay1orjones approved these changes

View reviewed changes

sstrubberg approved these changes

View reviewed changes


          Merge branch 'main' into add-default-label-to-modal-close

15c2b97

tay1orjones added the status: ready to merge 🎉 label

netlify bot commented Oct 29, 2021 •

edited

Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0edbd61

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617ca5277e737b0007015177

😎 Browse the preview: https://deploy-preview-9998--carbon-react-next.netlify.app

netlify bot commented Oct 29, 2021 •

edited

Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0edbd61

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617ca527aa7a1a0008064290

😎 Browse the preview: https://deploy-preview-9998--carbon-components-react.netlify.app

netlify bot commented Oct 29, 2021 •

edited

Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0edbd61

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617ca527c9aa06000709242f

😎 Browse the preview: https://deploy-preview-9998--carbon-elements.netlify.app

tay1orjones and others added 2 commits

October 29, 2021 15:05


          Merge branch 'main' into add-default-label-to-modal-close

489a85a


          Merge branch 'main' into add-default-label-to-modal-close

0edbd61

kodiakhq bot merged commit 7d4c511 into carbon-design-system:main

tay1orjones mentioned this pull request

v10.47.1 #10024

Closed

tay1orjones added a commit to tay1orjones/carbon that referenced this pull request


          fix(Modal): add closeButtonLabel prop, add default value (carbon-desi…

ee6ee20

…gn-system#9998)

Co-authored-by: Scott Strubberg <[email protected]>
Co-authored-by: Taylor Jones <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready to merge 🎉