Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(search): update color tokens #9971

Closed
wants to merge 3 commits into from
Closed

style(search): update color tokens #9971

wants to merge 3 commits into from

Conversation

motou
Copy link
Contributor

@motou motou commented Oct 27, 2021

REF #9888

Update color tokens to v11 based on the following specs: https://github.com/carbon-design-system/carbon/blob/main/docs/migration/11.x-color.md

  • Replaced compat theme with theme.
  • Updated the following:
    • disabled-01 -> text-on-color-disabled
    • disabled-01 -> field-disabled

@motou motou requested a review from a team as a code owner October 27, 2021 19:29
@motou motou requested review from sstrubberg and dakahn October 27, 2021 19:29
@@ -71,11 +71,11 @@
.#{$prefix}--search-input[disabled] {
border-bottom: 1px solid transparent;
background-color: $field-disabled;
color: $disabled-01;
color: $text-on-color-disabled;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a regression bug. Since $field-disabled is equal to $disabled-01, it means that the text color and the background color of a disabled search input are the same.

Hence I changed the text color to $text-on-color-disabled (equal to $disabled-03)

@netlify
Copy link

netlify bot commented Oct 27, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 8857b21

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c4ebe6cfec500082f5619

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8857b21

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c4ebefd21db0007a96925

😎 Browse the preview: https://deploy-preview-9971--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8857b21

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c4ebeed613100075ec433

😎 Browse the preview: https://deploy-preview-9971--carbon-elements.netlify.app

@sstrubberg
Copy link
Member

@motou i beat you to the punch :)

#9993

@tay1orjones
Copy link
Member

Thanks so much for the contribution here @motou and for adding the feedback suggestion on Scott's PR! I'm going to close this as a duplicate since we've already got some eyes from the design team over on the other PR.

@tay1orjones
Copy link
Member

Duplicate of #9993

@tay1orjones tay1orjones marked this as a duplicate of #9993 Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants