feat(RadioButton): refactor radio btn and btn group to functional components #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 9a71689 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6179de22ad17f80008239504 😎 Browse the preview: https://deploy-preview-9940--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9a71689 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6179de226c5af20008e0bfd9 😎 Browse the preview: https://deploy-preview-9940--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9a71689 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6179de2292c14400087b17ea 😎 Browse the preview: https://deploy-preview-9940--carbon-elements.netlify.app |
joshblack
suggested changes
Oct 26, 2021
packages/react/src/components/RadioButtonGroup/next/RadioButtonGroup.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/RadioButtonGroup/next/RadioButtonGroup.js
Outdated
Show resolved
Hide resolved
sstrubberg
reviewed
Oct 26, 2021
sstrubberg
reviewed
Oct 26, 2021
…nGroup.js Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Scott Strubberg <[email protected]>
Co-authored-by: Scott Strubberg <[email protected]>
sstrubberg
approved these changes
Oct 27, 2021
joshblack
approved these changes
Oct 27, 2021
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…ign-system#10080) ### Related Ticket(s) Closes carbon-design-system#9940 ### Description This PR takes a new approach, and offers some advantages of carbon-design-system#9941. While the other PR aims to separate class definitions from their registration in the browser, and should work well for teams or projects that wish to _extend_ C4IBM components, it does nothing to solve the problem for teams that are _double-consuming_ C4IBM components. For example, consider the widget team: - They are building widgets using the react-wrapper version of the components - When the react component imports the element, it brings along its `customElements.define()` method - The widget is placed on a page that is already using the C4IBM CDN links, which _also_ bring along the `customElements.define()` method. - Both the widget script and the CDN link are rolled up into separate scripts and whichever one runs second will encounter the unexpected error, not know how to handle that problem, and halt execution of the script, likely leaving large pieces of setup functionality unprocessed This new approach offers a method for elements to _attempt_ to define themselves, but to gracefully handle the failure and to continue executing the remainder of the running script. The new decorator is a simple copy/paste from the LitElement `@customElement` decorator, with the `customElements.define` functions wrapped in a try/catch block. As of right now, this only impacts one component and is simply a proof-of-concept. ### Changelog **New** - Adds a `@carbonElement()` decorator to the carbon-web-components package **Changed** - Edit the carbon-web-components package's accordion-item component to use @CarbonElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9712
Changelog
RadioButtonRadioButtonGroup/nextfolder (these tests were just copied over from v10, nothing changed).Testing / Reviewing
margin-bottomto labels inside input components #9947