-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooltip): prevent escape keydown from bubbling #9875
fix(tooltip): prevent escape keydown from bubbling #9875
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 68a8ff3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/616dc6f18c2c670007de2bc8 😎 Browse the preview: https://deploy-preview-9875--carbon-react-next.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo! Looks good to me 🎉
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 68a8ff3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/616dc6f1333e290007d790ec 😎 Browse the preview: https://deploy-preview-9875--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 68a8ff3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/616dc6f158a3b90008955c2b 😎 Browse the preview: https://deploy-preview-9875--carbon-components-react.netlify.app |
Co-authored-by: Scott Strubberg <[email protected]>
Closes #8502
Prevents the
escape
from bubbling throughonKeyDown
onTooltip
. Includes a new test to cover this functionality. I had to more thoroughly mock the debounce to include thecancel()
Tooltip uses.Changelog
Changed
Testing / Reviewing
⚠️ The story needs reverted before this is merged⚠️ Edit: removed ✅