Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Carbon React): update Downshift to v6.1.7 #9839

Closed

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Oct 11, 2021

We're a version behind Downshift and there's a few bugs hanging around our drop down components. Before we open tickets for fixes I figured we should get this work done.

Testing / Reviewing

We should make sure there are no regression for Downshift components:

  • Dropdown
  • Multiselect
  • ComboBox

Notes

Upgrading has broken Multiselect's tests

@dakahn dakahn requested a review from a team as a code owner October 11, 2021 20:18
@dakahn dakahn requested review from aledavila and abbeyhrt October 11, 2021 20:18
@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 98952e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6164c6fc1d618e0008f39f0c

😎 Browse the preview: https://deploy-preview-9839--carbon-react-next.netlify.app

@dakahn dakahn requested a review from tay1orjones October 11, 2021 20:18
@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 98952e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6164c6fcb8366a00075b1653

😎 Browse the preview: https://deploy-preview-9839--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 98952e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6164c6fcb673df0007e8c447

😎 Browse the preview: https://deploy-preview-9839--carbon-components-react.netlify.app

@dakahn
Copy link
Contributor Author

dakahn commented Oct 11, 2021

Seems like Simulate.click is no longer working after the update.

@dakahn
Copy link
Contributor Author

dakahn commented Oct 11, 2021

Looks like -- at least on 1 test -- swapping Simulate for fireEvent and specifying the actual clickable label that opens the MultiSelect titleText fixed that test. Putting a pin on this but @tay1orjones i can pick up this work next sprint 👍🏾

@dakahn
Copy link
Contributor Author

dakahn commented Oct 25, 2021

Taking reviewers off this since it's a WIP im coming back to in a later sprint 🏄🏾

@dakahn dakahn self-assigned this Oct 25, 2021
@joshblack joshblack closed this Dec 7, 2021
@tay1orjones tay1orjones mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants