-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Carbon React): update Downshift to v6.1.7 #9839
chore(Carbon React): update Downshift to v6.1.7 #9839
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 98952e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6164c6fc1d618e0008f39f0c 😎 Browse the preview: https://deploy-preview-9839--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 98952e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6164c6fcb8366a00075b1653 😎 Browse the preview: https://deploy-preview-9839--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 98952e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6164c6fcb673df0007e8c447 😎 Browse the preview: https://deploy-preview-9839--carbon-components-react.netlify.app |
Seems like |
Looks like -- at least on 1 test -- swapping |
Taking reviewers off this since it's a WIP im coming back to in a later sprint 🏄🏾 |
We're a version behind Downshift and there's a few bugs hanging around our drop down components. Before we open tickets for fixes I figured we should get this work done.
Testing / Reviewing
We should make sure there are no regression for Downshift components:
Notes
Upgrading has broken Multiselect's tests