Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react,carbon-react): add layer stories #9838

Merged
merged 8 commits into from
Oct 21, 2021
Merged

feat(react,carbon-react): add layer stories #9838

merged 8 commits into from
Oct 21, 2021

Conversation

abbeyhrt
Copy link
Contributor

Partially addresses #9763

This PR adds examples of components using the new Layer component instead of light prop. It also deprecates the light prop in the relevant components.

Changelog

New

  • with Layer story for various components

Changed

  • {{change thing}}

Removed

  • deprecates light prop

Testing / Reviewing

Check the new stories out and make sure everything looks okay.

@abbeyhrt abbeyhrt requested a review from a team as a code owner October 11, 2021 20:08
@netlify
Copy link

netlify bot commented Oct 11, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 4cf39c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6171b10a6c99790007fcc434

@netlify
Copy link

netlify bot commented Oct 11, 2021

❌ Deploy Preview for carbon-components-react failed.
Built without sensitive environment variables

🔨 Explore the source changes: 4cf39c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6171b10a7445d00007a0d998

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4cf39c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6171b10ad321f100075a18b6

😎 Browse the preview: https://deploy-preview-9838--carbon-elements.netlify.app

@abbeyhrt abbeyhrt requested a review from aledavila October 14, 2021 21:59
@abbeyhrt abbeyhrt changed the title feat(react,carbon-react): add layer stories and deprecate light prop feat(react,carbon-react): add layer stories Oct 14, 2021
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled these down and ran em. These seem good to me barring and changes requested above

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kodiakhq kodiakhq bot merged commit 22cdc87 into carbon-design-system:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants