-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react,carbon-react): add layer stories #9838
feat(react,carbon-react): add layer stories #9838
Conversation
❌ Deploy Preview for carbon-react-next failed. 🔨 Explore the source changes: 4cf39c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6171b10a6c99790007fcc434 |
❌ Deploy Preview for carbon-components-react failed. 🔨 Explore the source changes: 4cf39c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6171b10a7445d00007a0d998 |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 4cf39c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6171b10ad321f100075a18b6 😎 Browse the preview: https://deploy-preview-9838--carbon-elements.netlify.app |
…at/add-layer-stories
…n-fork into feat/add-layer-stories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled these down and ran em. These seem good to me barring and changes requested above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Partially addresses #9763
This PR adds examples of components using the new
Layer
component instead oflight
prop. It also deprecates thelight
prop in the relevant components.Changelog
New
with Layer
story for various componentsChanged
Removed
light
propTesting / Reviewing
Check the new stories out and make sure everything looks okay.