feat(checkbox): add onClick prop #9827
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: a152be4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6165d318a83e840007df0770 😎 Browse the preview: https://deploy-preview-9827--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: a152be4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6165d3183f454200071cc551 😎 Browse the preview: https://deploy-preview-9827--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: a152be4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6165d318c478850007375da6 😎 Browse the preview: https://deploy-preview-9827--carbon-elements.netlify.app |
There was a problem hiding this comment.
@tay1orjones Looks good to me! I'm only seeing onChange being called in the Playground but that seems like the same problem as the other PR adding an onClick recently, where the new event showed up locally but not in the deploy preview.
This reverts commit dd1d037.
This reverts commit dd1d037. Co-authored-by: Abbey Hart <[email protected]>
### Related Ticket(s) Closes carbon-design-system#9827 ### Description the `refBottom` needs to be compared to the `containerTop`, so that the menu sticks to the bottom of button Example (using local `yarn pack`: https://codesandbox.io/p/devbox/test-overflowmenu-t4slfp?file=%2F.codesandbox%2Ftasks.json%3A1%2C241 live demo: https://t4slfp-9000.csb.app/ ### Changelog **New** - {{new thing}} **Changed** - changed `refBottom` to a let and then equal `refBottom = refBottom - containerTop;` - ^ wondering if this can be cleaned up code wise, but testing locally with overflow-menu it seems successful **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Closes #9577
Adds an
onClickhandler to thedivwrapping the checkboxinputand itsspanlabel.Make note of the code comments I added. I'm curious if there's any additional perspectives on how to solve this issue.
Changelog
New
onClickhandlerTesting / Reviewing
onChangeonClickwithevent.targetindicating thespanonClickwithevent.targetindicating theinput