Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repo): add design defect issue template #9826

Merged
merged 2 commits into from
Oct 11, 2021
Merged

chore(repo): add design defect issue template #9826

merged 2 commits into from
Oct 11, 2021

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Oct 8, 2021 •
edited
Loading

Adds a new issue template geared towards design defects.

@laurenmrice pointed out how the existing bug report can be difficult for non-devs to fill out since it requires the codesandbox link. This new template replaces that field with a new field for screenshots.

Let me know if there's other things we should add or remove to improve this.

@tay1orjones tay1orjones requested a review from a team as a code owner October 8, 2021 16:32
@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b395085

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61644d694922d100078d6117

😎 Browse the preview: https://deploy-preview-9826--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b395085

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61644d691f8998000715628a

😎 Browse the preview: https://deploy-preview-9826--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b395085

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61644d69c369b800076a5dde

😎 Browse the preview: https://deploy-preview-9826--carbon-components-react.netlify.app

aagonzales
aagonzales approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The 🎨 icon is fine

laurenmrice
laurenmrice approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for doing this so quickly! 🎉

alisonjoseph
alisonjoseph approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit 19256b3 into carbon-design-system:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@aagonzales aagonzales aagonzales approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@sstrubberg sstrubberg Awaiting requested review from sstrubberg sstrubberg was automatically assigned from carbon-design-system/developers-system

@dakahn dakahn Awaiting requested review from dakahn dakahn was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tay1orjones @alisonjoseph @aagonzales @laurenmrice