-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accordion): update arrow spacing for start variant #9777
fix(accordion): update arrow spacing for start variant #9777
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 6ea0730 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615b311399c077000805d1c1 😎 Browse the preview: https://deploy-preview-9777--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6ea0730 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615b3113e08f400008528b5a 😎 Browse the preview: https://deploy-preview-9777--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6ea0730 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615b3113b843c00007419056 😎 Browse the preview: https://deploy-preview-9777--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding it to the styles
package as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the fix!
@aagonzales could you verify this is all up to spec? It's a visual bug fix for start chevron accordions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the chevrons in the "start"-variant of the Accordion (with the chevrons on the left) have 8px of left spacing whereas the chevrons in the "end"-variant (with the chevrons on the right) have a right spacing of 16px.
After checking with @aagonzales, the left spacing on the "start"-variant should also be 16px / spacing-05.
Before
After
Changelog
Changed
$spacing-05
/16px.$spacing-05
/16px spacing to the right of the accordion title based on spec from @aagonzales:Testing / Reviewing