Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): actionable non-inline content close button layout bug #9773

Conversation

tay1orjones
Copy link
Member

Fixes ActionableNotification - content text was running into the close button due to an improperly scoped style.

Changelog

Changed

  • ActionableNotification: text content wraps to respect close button layout

Testing / Reviewing

  • View the ActionableNotification story in the carbon-next storybook.
  • Put some text into the children prop control
  • Validate text doesn't wrap into the close button
  • Make inline prop true, and do the same test to ensure no regressions for inline variant.
Screenshots
bug 🐞 fixed ✅
Screen Shot 2021-09-29 at 3 07 01 PM Screen Shot 2021-09-29 at 3 20 37 PM

@tay1orjones tay1orjones requested a review from a team as a code owner September 29, 2021 20:28
@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d6c3ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615b79fc81b2e0000732b4f1

😎 Browse the preview: https://deploy-preview-9773--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d6c3ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615b79fc81b2e0000732b4ef

😎 Browse the preview: https://deploy-preview-9773--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d6c3ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615b79fb71eb6f0007b852a0

😎 Browse the preview: https://deploy-preview-9773--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit cd6fc39 into carbon-design-system:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants