Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carbon-react): remove label from default props #9731

Merged

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Sep 23, 2021

partially closes #9466

Removes various labelling from defaultProps for v11 🏄🏾

Changelog

Changed

  • src/components/OverflowMenu/OverflowMenu.js
  • src/components/Switch/Switch.js

Testing / Reviewing

In a v11 feature flagged environment test and see (via the Storys i'd suppose) if omitting proper labeling causes a console error from React 🦖

attn @abbeyhrt

@dakahn dakahn requested a review from a team as a code owner September 23, 2021 23:17
@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 6b1f12a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/618982ff5bd07900080897a7

😎 Browse the preview: https://deploy-preview-9731--carbon-react-next.netlify.app/

@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 6b1f12a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/618982ff41e4d10007051c2b

😎 Browse the preview: https://deploy-preview-9731--carbon-components-react.netlify.app/

@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 6b1f12a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618982ff5bfd7300080e6a49

😎 Browse the preview: https://deploy-preview-9731--carbon-elements.netlify.app

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think there was another one in OverflowMenuItem that needs to be updated too

@joshblack joshblack changed the title feat(Carbon-React): remove label from default props feat(carbon-react): remove label from default props Sep 27, 2021
Comment on lines +101 to +103
ariaLabel: FeatureFlags.enabled('enable-v11-release')
? PropTypes.string.isRequired
: PropTypes.string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this component, are we looking for ariaLabel or iconDescription to be the accessibility label for the component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured iconDescription was not necessarily the accessibility label

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be specified but we would still allow a default?

packages/react/src/components/Switch/Switch.js Outdated Show resolved Hide resolved
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I blanked on this! Looks good

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry! Looks good to me, sorry for ignoring it for so long!

@kodiakhq kodiakhq bot merged commit c06edfa into carbon-design-system:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not provide accessible labels by default, for example: "Provide icon description"
3 participants