Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(props): update table expand header props #9659

Merged
merged 11 commits into from
Oct 6, 2021
Merged

feat(props): update table expand header props #9659

merged 11 commits into from
Oct 6, 2021

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Sep 14, 2021 •
edited
Loading

Changelog

This updates table expand header. There are still questions if accordion item: if we truly need the renderExpand prop and what its purpose is.

Changed

  • changed prop names for TableHeaderExpand
  • enableExpando > enableToggle

@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e2600de

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615d43ab1036000007a58ad4

😎 Browse the preview: https://deploy-preview-9659--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 18f72e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6140d819827c7e0008bcafcd

😎 Browse the preview: https://deploy-preview-9659--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 18f72e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6140d81af2bbae0007a995c1

😎 Browse the preview: https://deploy-preview-9659--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e2600de

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615d43ab8fde2f00070e9b6d

😎 Browse the preview: https://deploy-preview-9659--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e2600de

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615d43ab93fcfb00077caf3b

😎 Browse the preview: https://deploy-preview-9659--carbon-components-react.netlify.app

@aledavila aledavila changed the title [WIP] feat(props): update accordion and table expand header props [WIP] feat(props): update table expand header props Sep 29, 2021
@aledavila aledavila marked this pull request as ready for review September 29, 2021 14:17
@aledavila aledavila requested review from a team as code owners September 29, 2021 14:17
@aledavila aledavila changed the title [WIP] feat(props): update table expand header props feat(props): update table expand header props Sep 29, 2021
abbeyhrt
abbeyhrt reviewed Sep 29, 2021
View reviewed changes
packages/react/src/components/DataTable/TableExpandHeader.js Outdated
// enableExpando:PropTypes.bool,
enableExpando: deprecate(
PropTypes.bool,
'The `renableExpando` prop has been deprecated in favor of `enableToggle`. This prop will be removed in the next major release.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'The `renableExpando` prop has been deprecated in favor of `enableToggle`. This prop will be removed in the next major release.'
'The `enableExpando` prop has been deprecated in favor of `enableToggle`. This prop will be removed in the next major release.'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch thanks

abbeyhrt
abbeyhrt approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than a very small typo 🎉

@kodiakhq kodiakhq bot merged commit 75646c0 into carbon-design-system:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledavila @abbeyhrt @andreancardona @jnm2377