chore(Tabs): added prop deprecation warnings for v11 #9644
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 7c05a14 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6140b1566b50fc00081c3479 😎 Browse the preview: https://deploy-preview-9644--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 7c05a14 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6140b155f2e8cb00091d6389 😎 Browse the preview: https://deploy-preview-9644--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 7c05a14 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6140b155c234de00073f21d4 😎 Browse the preview: https://deploy-preview-9644--carbon-components-react.netlify.app |
sstrubberg
changed the title
| /** | ||
| * A handler that is invoked when a user clicks on the control. | ||
| * Reserved for usage in Tabs | ||
| */ | ||
| onTabClick: PropTypes.func, | ||
|
|
||
| /** | ||
| * A handler that is invoked on the key down event for the control. | ||
| * Reserved for usage in Tabs | ||
| */ | ||
| onTabKeyDown: PropTypes.func, | ||
|
|
There was a problem hiding this comment.
For this component, would we want handleTabClick to go to onClick versus onTabClick?
There was a problem hiding this comment.
I agree with @joshblack, the Tabs container/parent component has an onClick prop. We'd want to mirror that hear. Other than that looks good to me!
REF #9535
Changelog
Tab.Testing / Reviewing
Tabstories and make sure everything is firing off as it should.