Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): Fix tooltip alignment aligned on right hand side of container #9606

Merged
merged 6 commits into from
Oct 6, 2021

Conversation

TuxedoFish
Copy link
Contributor

Closes #9561

  • When tooltip is aligned up against RHS the tooltip appears out of position

Changelog

New

  • N/A

Changed

  • Add a callback to setState(floatingPosition:...) inside _updateMenuSize
  • Will refire _updateMenuSize if the new bounding rectangle is different
  • This can only be fired once

Removed

  • N/A

Testing / Reviewing

  • Align the tooltip up against the RHS and see that the tooltip is correctly positioned

@TuxedoFish TuxedoFish requested a review from a team as a code owner September 5, 2021 20:41
@netlify
Copy link

netlify bot commented Sep 5, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d607f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615d49442f24d000088b7ba5

😎 Browse the preview: https://deploy-preview-9606--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 5, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7a478c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61352b97cd9a9d0007925802

😎 Browse the preview: https://deploy-preview-9606--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 5, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7a478c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61352b97ed0ae200082a238c

😎 Browse the preview: https://deploy-preview-9606--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 5, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d607f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615d4944678bbe0007a0218a

😎 Browse the preview: https://deploy-preview-9606--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 5, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d607f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615d49443026680008028cfa

😎 Browse the preview: https://deploy-preview-9606--carbon-elements.netlify.app

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. I compared to live tooltip story, and fix is working. 👍🏽 Thanks for the contribution! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip issue when aligned to right of screen
3 participants