Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carbon-react): remove un-exported experimental exports #9476

Merged
merged 3 commits into from
Aug 16, 2021
Merged

fix(carbon-react): remove un-exported experimental exports #9476

merged 3 commits into from
Aug 16, 2021

Conversation

joshblack
Copy link
Contributor

This PR removes unused experimental exports from @carbon/react that are not exported by carbon-components-react

Changelog

New

Changed

Removed

  • Unused exports from entrypoint for @carbon/react

Testing / Reviewing

  • Verify all exports from carbon-components-react are included in @carbon/react and no extra ones are included

@joshblack joshblack requested a review from a team as a code owner August 12, 2021 20:15
@netlify
Copy link

netlify bot commented Aug 12, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8e5eb71

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611a7d869650f10008ec781c

😎 Browse the preview: https://deploy-preview-9476--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 12, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8e5eb71

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611a7d857ace9300075618a7

😎 Browse the preview: https://deploy-preview-9476--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 12, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 8e5eb71

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611a7d8513d89c000759a033

😎 Browse the preview: https://deploy-preview-9476--carbon-components-react.netlify.app

aledavila
aledavila approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just need snapshot update

andreancardona
andreancardona approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like just the tests need to be updated :) @joshblack

@kodiakhq kodiakhq bot merged commit c047c05 into main Aug 16, 2021
@kodiakhq kodiakhq bot deleted the joshblack-patch-1 branch August 16, 2021 15:24
This was referenced Aug 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@aledavila aledavila aledavila approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @aledavila @andreancardona