-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): add skeleton sass modules and stories #9423
feat(styles): add skeleton sass modules and stories #9423
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 356d4b9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611eb84e94487b00075a44b6 😎 Browse the preview: https://deploy-preview-9423--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 356d4b9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611eb84e73b11400089e9223 😎 Browse the preview: https://deploy-preview-9423--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 356d4b9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611eb84ea96cb70007878aa8 😎 Browse the preview: https://deploy-preview-9423--carbon-components-react.netlify.app |
@tay1orjones looks like the percy snapshot for CodeSnippet is failing bc in the snapshot it's missing the show more button. I checked out the story and it's there, it just took a second to load. I'm not touching any codesnippet styles here. Any thoughts on what I should do? |
@jnm2377 interesting! My first thought is to modify the codesnippet vrt and make sure |
@tw15egan @sstrubberg sorry for the delay, this is ready for re-review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Closes #9130
New
SkeletonPlaceholder
andSkeletonText
to@carbon/react
storiesTesting / Reviewing