Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): allow number as a valid proptype for selecteditems #9421

Merged
merged 5 commits into from
Aug 7, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Aug 4, 2021

Closes #9413

Allows number as a valid proptype for selectedItems and initialSelectedItems for Dropdown and Combobox

Changelog

Changed

  • Added number as a valid proptype for Dropdown, Combobox

Testing / Reviewing

Ensure no prop type warnings are emitted if a selectedItem is of type number

@tw15egan tw15egan requested a review from a team as a code owner August 4, 2021 18:38
@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d7c52ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610e34fc9cf5b10007665562

😎 Browse the preview: https://deploy-preview-9421--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d7c52ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610e34fc3e91390008b07e52

😎 Browse the preview: https://deploy-preview-9421--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d7c52ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610e34fc6588cd00088f8fa0

😎 Browse the preview: https://deploy-preview-9421--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit d7d4f2a into carbon-design-system:main Aug 7, 2021
This was referenced Aug 17, 2021
@tw15egan tw15egan deleted the prop-type-change branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown with number as selectedItem throws warning
3 participants