-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): allow number as a valid proptype for selecteditems #9421
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: d7c52ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610e34fc9cf5b10007665562 😎 Browse the preview: https://deploy-preview-9421--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: d7c52ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610e34fc3e91390008b07e52 😎 Browse the preview: https://deploy-preview-9421--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: d7c52ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610e34fc6588cd00088f8fa0 😎 Browse the preview: https://deploy-preview-9421--carbon-components-react.netlify.app |
Closes #9413
Allows
number
as a valid proptype forselectedItems
andinitialSelectedItems
forDropdown
andCombobox
Changelog
Changed
number
as a valid proptype forDropdown
,Combobox
Testing / Reviewing
Ensure no prop type warnings are emitted if a
selectedItem
is of type number