Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): added aria-label to tooltip content #9420

Merged
merged 4 commits into from
Aug 18, 2021
Merged

fix(tooltip): added aria-label to tooltip content #9420

merged 4 commits into from
Aug 18, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Aug 4, 2021 •
edited by dakahn
Loading

Closes #9229

  • Make sure accessibility checker passes on the tooltip and the text in the dialog is fully read. :)

@andreancardona andreancardona requested a review from dakahn August 4, 2021 18:28
@andreancardona andreancardona requested a review from a team as a code owner August 4, 2021 18:28
@andreancardona andreancardona requested a review from jnm2377 August 4, 2021 18:28
@netlify
Copy link

netlify bot commented Aug 4, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4d2c82f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611c6952cdde300007acd355

😎 Browse the preview: https://deploy-preview-9420--carbon-react-next.netlify.app

@andreancardona andreancardona marked this pull request as draft August 4, 2021 18:28
@andreancardona andreancardona mentioned this pull request Aug 4, 2021
Closed
@netlify
Copy link

netlify bot commented Aug 4, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4d2c82f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611c69523d9c1700079ee640

😎 Browse the preview: https://deploy-preview-9420--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 4d2c82f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611c6952ad69690007398d60

😎 Browse the preview: https://deploy-preview-9420--carbon-components-react.netlify.app

@andreancardona andreancardona marked this pull request as ready for review August 13, 2021 16:25
@dakahn dakahn changed the title [WIP] fix(tooltip): added aria-label to tooltip content fix(tooltip): added aria-label to tooltip content Aug 13, 2021
dakahn
dakahn approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JAWS 2020 on Windows 10 reads well! Looks like the error is clear too. Wonderful work 💪🏾

@kodiakhq kodiakhq bot merged commit 7d5667a into carbon-design-system:main Aug 18, 2021
@joshblack joshblack mentioned this pull request Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip a11y - dialog role needs name
3 participants
@andreancardona @jnm2377 @dakahn