Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add index.scss to npm files #9385

Merged

Conversation

joshblack
Copy link
Contributor

This adds in the index.scss file to packages that specify files. This is currently breaking re-exports from packages using Sass modules.

Changelog

New

Changed

  • Add index.scss to files array in package.json files

Removed

Testing / Reviewing

  • Verify all packages that have an index.scss and use a files array include index.scss in that files array

@joshblack joshblack requested a review from a team as a code owner August 2, 2021 20:29
@joshblack joshblack requested review from jnm2377 and dakahn August 2, 2021 20:29
@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b4ca483

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6109596ac8aca200072f9618

😎 Browse the preview: https://deploy-preview-9385--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b4ca483

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6109596ad5c74e00070652e0

😎 Browse the preview: https://deploy-preview-9385--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: b4ca483

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6109596acbf8bd0007c32b13

😎 Browse the preview: https://deploy-preview-9385--carbon-components-react.netlify.app

@sstrubberg sstrubberg enabled auto-merge (squash) August 3, 2021 15:10
@sstrubberg sstrubberg merged commit d854fe1 into carbon-design-system:main Aug 3, 2021
joshblack added a commit to joshblack/carbon that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants