Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): condensed gutter should be 1px #9361

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

tay1orjones
Copy link
Member

Small change to make the condensed grid gutter 1px instead of 2px for the new CSS Grid implementation.

Thanks @jeanservaas for catching this!

Changelog

Changed

  • css-grid: condensed gutter value updated to be 1px

Testing / Reviewing

The @carbon/react storybook should show the condensed grid having 1px gutter instead of 2px. Other modes and stories should not be impacted.

@tay1orjones tay1orjones requested a review from a team as a code owner July 29, 2021 16:04
@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 39b320a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61032ea365f45d0008561f89

😎 Browse the preview: https://deploy-preview-9361--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 39b320a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61032ea30685520007fde47d

😎 Browse the preview: https://deploy-preview-9361--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 39b320a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61032ea35a12020007ab4d3f

😎 Browse the preview: https://deploy-preview-9361--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit a3bbf26 into carbon-design-system:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants