Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carbon-react): add scss entrypoints #9353

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jul 28, 2021

Closes #9173

This PR adds in every public scss entrypoint to the @carbon/react package. There is a tasks/build-styles.js task that has been added to the package in order to automate this process. This file can be added to over time and is called manually to scaffold out style files.

Each style file calls @forward from the @carbon/styles entrypoint for the file.

Changelog

New

  • Add all scss entrypoints to @carbon/react
  • Add build-styles task to packages/carbon-react/tasks

Changed

Removed

Testing / Reviewing

  • Make sure storybook next styles work as expected
  • Verify that all public paths from @carbon/styles are available in @carbon/react

@joshblack joshblack requested a review from a team as a code owner July 28, 2021 20:18
@joshblack joshblack requested review from sstrubberg and dakahn July 28, 2021 20:18
@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: c54a25f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610333ca43fb54000761e1f5

😎 Browse the preview: https://deploy-preview-9353--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c5a3bf1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6101bb831ff63700083bcb83

😎 Browse the preview: https://deploy-preview-9353--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: c5a3bf1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6101bb834c0cf900081f8992

😎 Browse the preview: https://deploy-preview-9353--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c54a25f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610333cab4034e0008f8ff7e

😎 Browse the preview: https://deploy-preview-9353--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c54a25f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610333ca7033e10007772fab

😎 Browse the preview: https://deploy-preview-9353--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor Author

Let me know if you have any questions @dakahn @sstrubberg !

Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built real nice 👍🏽

@kodiakhq kodiakhq bot merged commit 4509b5f into carbon-design-system:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all public API re-exports to @carbon/react
3 participants