Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: left align text in sortable header #9329

Merged

Conversation

griffindvs
Copy link
Contributor

Closes #9327

Left aligns text in sortable header labels inside the DataTable component.

Changelog

New

  • Add text-align: left to Button elements with .bx--table-sort

Testing / Reviewing

  1. View the Sorting DataTable example in the Storybook
  2. Resize the window until a column header splits into multiple lines
  3. Check that the text is now left aligned

Screenshots:

Before:
Screen Shot 2021-07-26 at 4 09 48 PM

After:
Screen Shot 2021-07-26 at 4 09 15 PM

@griffindvs griffindvs requested a review from a team as a code owner July 26, 2021 21:10
@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 54fc579

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610324e51aff360008e1f4db

😎 Browse the preview: https://deploy-preview-9329--carbon-react-next.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2021

DCO Assistant Lite bot All contributors have signed the DCO.

@griffindvs
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 54fc579

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610324e53d0bb40008273379

😎 Browse the preview: https://deploy-preview-9329--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 54fc579

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610324e5931d870008801250

😎 Browse the preview: https://deploy-preview-9329--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit f0d1717 into carbon-design-system:main Jul 29, 2021
@griffindvs griffindvs deleted the 9327-datatable-header-align branch July 30, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Line DataTable Header is Center Aligned
4 participants