Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VRT for accordion and breadcrumb skeleton #9326

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jul 26, 2021

Closes #9263
Closed #9264

Modifies the existing e2e tests to render skeletons so they're included in the snapshots diffed by percy.io

Changelog

Changed

  • accordion: add skeleton to VRT
  • breadcrumb: add skeleton to VRT

Testing / Reviewing

  • Percy status check should fail and require approval of the new snapshot contents
  • The Percy UI should should show the skeleton components
  • Approve in the Percy UI if things look good

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: fe1a5ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610948337eb96600078edc0d

😎 Browse the preview: https://deploy-preview-9326--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fe1a5ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610948331d8fac00071793c0

😎 Browse the preview: https://deploy-preview-9326--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fe1a5ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610948338ab20a0007293059

😎 Browse the preview: https://deploy-preview-9326--carbon-components-react.netlify.app

@sstrubberg sstrubberg enabled auto-merge (squash) August 3, 2021 13:44
@sstrubberg sstrubberg merged commit cc00f4d into carbon-design-system:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VRT for BreadcrumbSkeleton Add VRT for AccordionSkeleton
3 participants