Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(font-family): added system fonts #9325

Merged
merged 7 commits into from
Aug 2, 2021

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Jul 26, 2021

Closes #8764

Updates font-families in the @carbon/type package with the following:

  • Arabic
  • Devanagari
  • JP
  • KR
  • Thai

Replaced all the Helvetica Neue stuff with system-ui, -apple-system, BlinkMacSystemFont, '.SFNSText-Regular', sans-serif

@sstrubberg sstrubberg requested a review from a team as a code owner July 26, 2021 19:54
@sstrubberg sstrubberg requested review from joshblack and tw15egan July 26, 2021 19:54
@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7b7336c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6104596aea9560000780d43f

😎 Browse the preview: https://deploy-preview-9325--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7b7336c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6104596a3082ed0008b141cf

😎 Browse the preview: https://deploy-preview-9325--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 7b7336c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6104596a04edab0008d26392

😎 Browse the preview: https://deploy-preview-9325--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

@sstrubberg I think we can keep the existing font stacks the same but use the system UI ones for the new fonts that we're going to be shipping through the Plex package. I think these include:

  • Arabic
  • Devanagari
  • JP
  • KR
  • Thai

What do you think? 👀

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit d45a224 into carbon-design-system:main Aug 2, 2021
@sstrubberg sstrubberg deleted the 8764-font-family branch August 2, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@carbon/type: determine ideal font family stack, and add as mixin to type package
3 participants