-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(font-family): added system fonts #9325
fix(font-family): added system fonts #9325
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 7b7336c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6104596aea9560000780d43f 😎 Browse the preview: https://deploy-preview-9325--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 7b7336c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6104596a3082ed0008b141cf 😎 Browse the preview: https://deploy-preview-9325--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 7b7336c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6104596a04edab0008d26392 😎 Browse the preview: https://deploy-preview-9325--carbon-components-react.netlify.app |
@sstrubberg I think we can keep the existing font stacks the same but use the system UI ones for the new fonts that we're going to be shipping through the Plex package. I think these include:
What do you think? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Closes #8764
Updates font-families in the
@carbon/type
package with the following:Replaced all the
Helvetica Neue
stuff withsystem-ui, -apple-system, BlinkMacSystemFont, '.SFNSText-Regular', sans-serif