Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): remove hardcoded prefixes #9321

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

tw15egan
Copy link
Collaborator

Closes #9320

Removes references to hardcoded prefixes

Changelog

Changed

  • Replaced instances of .bx with .#{$prefix}

Testing / Reviewing

Ensure the components that were changed still render as before

@tw15egan tw15egan requested a review from a team as a code owner July 26, 2021 14:14
@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: fe169e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6101bedfb3c04a000755610b

😎 Browse the preview: https://deploy-preview-9321--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fe169e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6101bedfb3c04a000755610d

😎 Browse the preview: https://deploy-preview-9321--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fe169e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6101bedf42842a00072aa2e0

😎 Browse the preview: https://deploy-preview-9321--carbon-components-react.netlify.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit 354bf5c into carbon-design-system:main Jul 28, 2021
@tw15egan tw15egan deleted the prefix-fix branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bx prefix is hardcoded in some selectors
3 participants