Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(feature-flags): run output through babel #9204

Merged
merged 3 commits into from
Jul 26, 2021
Merged

chore(feature-flags): run output through babel #9204

merged 3 commits into from
Jul 26, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 14, 2021 •
edited
Loading

related #8995

This PR runs the feature flags package output through Babel to support IE11. Although Storybook in IE11 will still be broken due to an upstream issue, there should no longer be any errors related to unsupported class usage (only the errors from Storybook should remain)

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 84cbdd7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60feccbdad211b000759e698

😎 Browse the preview: https://deploy-preview-9204--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 84cbdd7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60feccbd03b84700086687fc

😎 Browse the preview: https://deploy-preview-9204--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 84cbdd7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60feccbd0daa0d00096acce1

😎 Browse the preview: https://deploy-preview-9204--carbon-components-react.netlify.app

@emyarod emyarod mentioned this pull request Jul 14, 2021
Closed
@emyarod emyarod marked this pull request as ready for review July 22, 2021 15:18
@emyarod emyarod requested a review from a team as a code owner July 22, 2021 15:18
tw15egan
tw15egan approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@emyarod emyarod mentioned this pull request Jul 26, 2021
Closed
62 tasks
@kodiakhq kodiakhq bot merged commit aae08aa into carbon-design-system:main Jul 26, 2021
@emyarod emyarod deleted the 8995-feature-flags-babel-polyfills branch July 26, 2021 15:55
This was referenced Aug 3, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @joshblack @tw15egan