Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(grid): correct import paths, remove controls warning #9202

Merged

Conversation

tay1orjones
Copy link
Member

Closes #9179

Small improvements to the CSS Grid docs in the new @carbon/react storybook.

Changelog

Changed

  • fixed import paths
  • ensure the controls pane doesn't show warnings

Testing / Reviewing

Read through the Grid docs mdx in the new @carbon/react storybook - make sure it makes sense and is clear to you. Happy to field any questions and improve these in whatever way you think would be helpful!

@tay1orjones tay1orjones requested a review from a team as a code owner July 14, 2021 16:50
@tay1orjones tay1orjones requested review from emyarod and jnm2377 July 14, 2021 16:50
@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: c25fa8a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6102dd6e7033e100076d5a83

😎 Browse the preview: https://deploy-preview-9202--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c25fa8a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6102dd6e07f59f000733a10b

😎 Browse the preview: https://deploy-preview-9202--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c25fa8a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6102dd6e325e810007325acb

😎 Browse the preview: https://deploy-preview-9202--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit 92e0500 into carbon-design-system:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write usage docs for CSS Grid in @carbon/react, available on the storybook
3 participants